Skip to content

feat: add trashing #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 28, 2021
Merged

feat: add trashing #749

merged 11 commits into from
Nov 28, 2021

Conversation

RaafatTurki
Copy link
Contributor

fixes #279

adds the ability to trash with D, trash command and confirmation message are configurable in setup() which is documented as well.

@RaafatTurki
Copy link
Contributor Author

It's relocated now and much more inspired by fs.remove().
However an issue was brought to my attention, after trashing an item an R refresh is required to update the tree to its correct view.

I've thought I should give the trash process time to execute before doing a lib.refresh_tree() so I've tried doing it in on_exit() to no avail.

I don't have a good image on how nvimtree handles UI updates, I'd like you to take a look
here and here

Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just missing documentation in help file :)

@kyazdani42
Copy link
Member

CI complaining about unused arguments, please remove them if they are unused :)

@RaafatTurki
Copy link
Contributor Author

done

Co-authored-by: Kiyan <yazdani.kiyan@protonmail.com>
Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@kyazdani42 kyazdani42 merged commit e842f08 into nvim-tree:master Nov 28, 2021
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to trash instead of delete
4 participants